Refactor limit, offset #3120
Merged
Refactor limit, offset #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstepanov
commented
Sep 12, 2024
| */ | ||
| @Deprecated(forRemoval = true, since = "4.10") | ||
| String META_MEMBER_PAGE_SIZE = "pageSize"; |
There was a problem hiding this comment.
Old members are confusing, page size / index are always limit / offset
dstepanov
commented
Sep 12, 2024
| @@ -434,30 +436,63 @@ protected <RT> Optional<RT> getParameterInRole(MethodInvocationContext<?, ?> con | |||
| */ | |||
| @NonNull | |||
| protected Pageable getPageable(MethodInvocationContext<?, ?> context) { | |||
| Pageable pageable = getParameterInRole(context, TypeRole.PAGEABLE, Pageable.class).orElse(null); | |||
| Pageable pageable = getPageableInRole(context); | |||
| if (pageable == null) { | |||
There was a problem hiding this comment.
This method is confusing, we never store direct page index / size into metadata. Offset is never using in the implementation
radovanradic
approved these changes
Sep 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For MongoDB we don't need to store limit, offset in the metadata for the runtime.
For JBDC we can generate the SQL query directly if there is no runtime sorting.